Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/30#discussion_r71090203
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/connection/ModeledConnection.java
---
@@ -157,6 +158,12 @@ public void setConfiguration(GuacamoleConfiguration
config) {
}
@Override
+ public Set<String> getSharingProfileIdentifiers()
--- End diff --
No, it's just not implemented. These are the API changes only, with the
actual implementation of that API coming later.
I figured that if I held off on the review of the API until the underlying
implementation was complete, that would distract from the review of the API
design itself, and make the PR way too large.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
