Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/11#discussion_r71967090
--- Diff: src/common-ssh/guac_ssh.h ---
@@ -76,10 +76,10 @@ void guac_common_ssh_uninit();
/**
* Connects to the SSH server running at the given hostname and port, and
* authenticates as the given user. If an error occurs while connecting or
- * authenticating, the Guacamole client will automatically and fatally
abort.
- * The user object provided must eventually be explicitly destroyed, but
should
- * not be destroyed until this session is destroyed, assuming the session
is
- * successfully created.
+ * authenticating, the Guacamole client will only automatically and fatally
+ * abort if the abort_on_error parameter is set to 1 and errors will always
--- End diff --
As mentioned earlier, requiring `1` is odd for C. Better for this to simply
be non-zero. Other than that, still looking good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
