GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/39
GUACAMOLE-5: Separate sharing semantics from database-backed
AuthenticationProvider
The database authentication backend currently implements support for unique
"share keys", which can be used as an alternative and temporary method of
authentication for accessing shared connections. Prior to this change, it was
the duty of the `AuthenticationProvider` to handle both username/password
authentication *and* share key authentication.
This change splits the PostgreSQL/MySQL `AuthenticationProvider`
implementations into two: one which is specific to username/password auth
against the database, and the other which is specific to share key
authentication against in-memory shared connections. Both share a common Guice
`Injector` and, thus, a common set of core services. Collaborative management
of shared connections between the two is achieved through a common service
which handles registration and retrieval of shared connections and their
corresponding keys.
This change is architectural, as it is a necessary step to cleanly
implement support for use of multiple share keys within the same session, even
if that session was due to a username/password login. The existing
functionality is unaffected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
separate-auth-providers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/39.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #39
----
commit a59b0124b959398d9006539b447eca950510ddeb
Author: Michael Jumper <[email protected]>
Date: 2016-07-28T18:20:19Z
GUACAMOLE-5: Use singleton Guice Injector via common base class.
commit 2f5f31b7f46773085d7c5e82c00b38df9dfabda9
Author: Michael Jumper <[email protected]>
Date: 2016-07-29T00:16:03Z
GUACAMOLE-5: Use AuthenticationProviderService as the means of defining
AuthenticationProvider behavior.
commit 591ad4ac83ad079d395faa831bcd84ef1df0e901
Author: Michael Jumper <[email protected]>
Date: 2016-07-29T02:45:43Z
GUACAMOLE-5: Handle shared connections via dedicated AuthenticationProvider.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
