GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/42
GUACAMOLE-5: Provide most recent Credentials to updateUserContext()
The `updateUserContext()` function of `AuthenticationProvider` has existed
for a while, but it was written under the assumption that `AuthenticatedUser`
will always receive an updated set of credentials, thus the possibly-updated
`UserContext` will be able to access this information.
This is false. The `AuthenticatedUser` will only be updated if
`updateAuthenticatedUser()` does so, and relying on that is bad. There's not
much for `updateUserContext()` to update with if it can't be guaranteed access
to fresh information.
Updating `UserContext` may require peeking at the most recent HTTP request
/ credentials, so the most recent `Credentials` object should be passed to
`updateUserContext()` as well.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
provide-updated-credentials
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/42.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #42
----
commit abbc83a15bd4e34419561d889086d562385cca62
Author: Michael Jumper <[email protected]>
Date: 2016-07-29T22:14:39Z
GUACAMOLE-5: Provide most recent Credentials to updateUserContext(). Doing
otherwise relies on the AuthenticatedUser being updated, which is not
guaranteed to happen.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
