GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/45
GUACAMOLE-5: Add support for multiple share keys.
This change (finally) leverages the changes from the other recent PRs to
implement support for multiple share keys. Rather than create a `UserContext`
which is restricted to a single connection (the connection associated with the
share key), the initial share key only serves as the means of authentication if
no other means has been used. Any further share keys received via new
`Credentials` add further connections to the existing `UserContext`.
This has the effect that:
1. Legitimate users of the Guacamole system can use share keys without
logging out first.
2. Accessing a shared connection while logged in as a normal Guacamole user
causes the correct username to be recorded in the history.
3. Clicking a share key while already in a Guacamole session results in
that connection being added to the existing session, rather than having no
effect at all.
This change also leverages the HTML patching features of the extension
subsystem to add a nifty "shared by" tag next to the shared connection in the
home screen, now that such a thing can exist:
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
multiple-share-keys
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit 96094a1c5842b470356a35d7959fa22774e5b24f
Author: Michael Jumper <[email protected]>
Date: 2016-07-29T21:36:11Z
GUACAMOLE-5: Implement exposure of a dynamic set of share keys as
connections within a connection directory.
commit ecaf5be84eb643b1bf9a697c77daae2845c5d3b2
Author: Michael Jumper <[email protected]>
Date: 2016-07-29T22:33:13Z
GUACAMOLE-5: Update the SharedUserContext whenever a new share key is used.
commit ff3c57dff058f0f19c2ef9381cf1f4c607c0ab19
Author: Michael Jumper <[email protected]>
Date: 2016-07-30T00:47:16Z
GUACAMOLE-5: Display the username of the user that shares a connection.
commit c2f429360ca96a2b0e0198f83c864dc2a76213f9
Author: Michael Jumper <[email protected]>
Date: 2016-07-30T06:05:27Z
GUACAMOLE-5: Use connection name for SharedConnection, not sharing profile
name.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
