GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/49
GUACAMOLE-5: Define both connection and sharing profile parameters.
The `ProtocolInfo` object (and the `Protocol` object in JavaScript) only
define parameters from the perspective of connections. As sharing profiles will
not necessarily use the exact same connection parameters, these parameters need
to be defined independently.
This change splits the old `forms` property of `Protocol` into
`connectionForms` and `sharingProfileForms`, such that connections and sharing
profiles need not share the exact same parameters. An analogous change is made
to `ProtocolInfo`.
As the only parameter currently supported by Guacamole's VNC, RDP, SSH, and
telnet for joining connections is "read-only", that is the only parameter added
to the JSON here.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
share-parameters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/49.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #49
----
commit 14365ff72ec6490ae876d5c6c5c63a5a7f070620
Author: Michael Jumper <[email protected]>
Date: 2016-08-08T05:50:26Z
GUACAMOLE-5: Define connection and sharing profile parameters separately.
commit 94ce151f69a7cbe5b98f86d9f7997c498955bb6c
Author: Michael Jumper <[email protected]>
Date: 2016-08-08T04:21:57Z
GUACAMOLE-5: Add "read-only" parameter to all protocols.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
