Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/68#discussion_r77440056
  
    --- Diff: extensions/guacamole-auth-ldap/README ---
    @@ -91,6 +91,11 @@ guacamole.properties such that the authentication 
provider is available.
     
         # The base DN within which all role based groups can be found.
         ldap-group-base-dn:      ou=groups,dc=example,dc=net
    +    
    +    # The additional search filter for the user to be authenticated. 
    +    # for example , following filter indicate user have to be memeberof 
exampleGroup. otherwise, authentication will failed.
    +    #the filter is also used to filter out all users visible to guacadmin
    +    ldap-additional-search-filter: 
(memberOf=cn=exampleGroup,ou=groups,dc=example,dc=net) 
    --- End diff --
    
    "ldap-additional-search-filter" and "The additional search filter for the 
user to be authenticated" don't really provide enough information to be a 
useful property name and description. Can you think of something more 
descriptive? Something which inherently implies, at a high level, what this 
property is used for?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to