GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/99
GUACAMOLE-36: Support fully translatable messages
Extensions are already capable of throwing error messages which are
translatable (the error message can be a translation key), but there is no way
for substitution/pluralization to occur, and thus no way to include dynamic
values within such messages.
This change defines a JSON format and mechanism for throwing translatable
error messages from extensions, allowing for substitution of arbitrary values
and pluralization within the JavaScript side of the web application.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
translatable-messages
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/99.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #99
----
commit c5471afaed4326282c78d04baa9c5c728f402bc3
Author: Michael Jumper <[email protected]>
Date: 2016-08-16T05:24:04Z
GUACAMOLE-36: Generalize and simplify handling of REST API errors.
commit 9b56200a1889f653988db802514eb4e4bd246ebd
Author: Michael Jumper <[email protected]>
Date: 2016-08-17T02:31:48Z
GUACAMOLE-36: Define REST API transfer mechanism for translatable messages.
commit fff7f71c7ae1c60a27332b8c4957e733f2fbbad7
Author: Michael Jumper <[email protected]>
Date: 2016-08-17T04:47:26Z
GUACAMOLE-36: Migrate guacLogin and guacNotification to TranslatableMessage.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
