Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/102#discussion_r94853826
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/user/ModeledUser.java
---
@@ -189,10 +189,10 @@
private String password = null;
/**
- * The time and date that this user's password was previously set
(prior to
- * being queried). If the user is new, this will be null.
+ * The data associated with this user's password at the time this user
was
+ * queried. If the user is new, this will be null.
*/
- private Timestamp previousPasswordDate = null;
--- End diff --
Perhaps the `getPreviousPassword()` naming is overly confusing? It only
makes sense when the password has been reset via `setPassword()` on the user
ovject, since it continues to refer to the historical data of the password that
was set at the time the model was retrieved.
I'm open to suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
