GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/107
GUACAMOLE-172: Do not send potentially-invalid "sync" as a keep-alive.
This change alters the keep-alive ping of `Guacamole.Client` such that it
sends a `nop` instruction rather than a `sync`. If the keep-alive ping occurs
prior to receipt of the first frame (no `sync` has been received), then sending
the `sync` is a protocol violation. The fact that `currentTimestamp` would be 0
in that case only makes matters worse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
fix-bad-sync
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/107.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #107
----
commit 41881be909ee933d80f1e22fed6b14e0d912ce8b
Author: Michael Jumper <[email protected]>
Date: 2017-01-15T22:00:20Z
GUACAMOLE-172: Do not send potentially-invalid "sync" as a keep-alive. Use
"nop" instead.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
