Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-server/pull/42#discussion_r97693112
  
    --- Diff: src/common/common/surface.h ---
    @@ -317,10 +363,77 @@ void guac_common_surface_clip(guac_common_surface* 
surface, int x, int y, int w,
     void guac_common_surface_reset_clip(guac_common_surface* surface);
     
     /**
    - * Flushes the given surface, drawing any pending operations on the remote
    - * display.
    + * Changes the location of the surface relative to its parent layer. If the
    + * surface does not represent a non-default visible layer, then this 
function
    + * has no effect.
      *
    - * @param surface The surface to flush.
    + * @param surface
    + *     The surface to move relative to its parent layer.
    + *
    + * @param x
    + *     The new X coordinate for the upper-left corner of the layer, in 
pixels.
    + *
    + * @param y
    + *     The new Y coordinate for the upper-left corner of the layer, in 
pixels.
    + */
    +void guac_common_surface_move(guac_common_surface* surface, int x, int y);
    +
    +/**
    + * Changes the stacking order of the surface relative to other surfaces 
within
    + * the same parent layer. If the surface does not represent a non-default
    + * visible layer, then this function has no effect.
    + *
    + * @param surface
    + *     The surface to move relative to its parent layer.
    + *
    + * @param z
    + *     The new Z-order for this layer, relative to sibling layers.
    + */
    +void guac_common_surface_stack(guac_common_surface* surface, int z);
    +
    +/**
    + * Changes the parent layer of ths given surface. By default, layers will 
be
    + * children of the default layer. If the surface does not represent a
    + * non-default visible layer, then this function has no effect.
    + *
    + * @param surface
    + *     The surface whose parent layer should be changed.
    + *
    + * @param parent
    + *     The layer which should be set as the new parent of the given 
surface.
    + */
    +void guac_common_surface_set_parent(guac_common_surface* surface,
    +        const guac_layer* parent);
    +
    +/**
    + * Sets the opacity of the surface. If the surface does not represent a
    + * non-default visible layer, then this function has no effect.
    + *
    + * @param surface
    + *     The surface to move relative to its parent layer.
    --- End diff --
    
    Sigh ... yet more copypasta ... 🍝 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to