Github user jmuehlner commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/57#discussion_r98610868
--- Diff: src/terminal/terminal.c ---
@@ -847,6 +847,45 @@ int guac_terminal_clear_range(guac_terminal* term,
}
+/**
+ * Returns whether the given character would be visible relative to the
+ * background of the given terminal.
+ *
+ * @param term
+ * The guac_terminal to test the character against.
+ *
+ * @param c
+ * The character being tested.
+ *
+ * @return
+ * true if the given character is different from the terminal
background,
+ * false otherwise.
+ */
+static bool guac_terminal_is_visible(guac_terminal* term,
+ guac_terminal_char* c) {
+
+ /* Continuation characters are NEVER visible */
+ if (c->value == GUAC_CHAR_CONTINUATION)
+ return false;
+
+ /* Characters with glyphs are ALWAYS visible */
+ if (guac_terminal_has_glyph(c->value))
+ return true;
+
+ int background;
+
+ /* Determine actual background color of character */
+ if (c->attributes.reverse != c->attributes.cursor)
--- End diff --
I'm not sure I understand what this check is about - comparing the reverse
attribute to the cursor attribute?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
