Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/125#discussion_r103524133
--- Diff: extensions/guacamole-auth-duo/pom.xml ---
@@ -209,19 +209,11 @@
<dependencies>
- <!-- Guacamole Java API -->
- <dependency>
--- End diff --
Ah, OK.
I removed them as a part of the version number bump because of the need to
check whether those numbers get bumped as well in each case. Normally, I'm an
extreme proponent of "include what you use", but guacamole-common in this case
is not independently used by the code; it's only used as required to interact
with parts of guacamole-ext.
There's some discussion on this here:
http://stackoverflow.com/questions/4226756/maven-should-i-keep-or-remove-declared-dependencies-that-are-also-transitives
IMHO: it's not a logical dependency of these extensions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
