Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/74#discussion_r107077170
--- Diff: src/libguac/timestamp.c ---
@@ -33,9 +33,21 @@ guac_timestamp guac_timestamp_current() {
struct timespec current;
- /* Get current time */
+ /* Get current time, monotinically increasing.
+ guacd expects that a client sync timestamp <= last_sent_timestamp.
+ When time moves backwards, when last_sent_timestamp can move back,
+ violating the assumption of forward moving time.
+ Ex. Obsorved a Azure Linux instance,
--- End diff --
observed*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
