Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-manual/pull/38#discussion_r107335467
  
    --- Diff: src/chapters/ldap-auth.xml ---
    @@ -384,6 +384,17 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
                                     have no effect on Guacamole 
configurations.</emphasis></para>
                         </listitem>
                     </varlistentry>
    +                <varlistentry>
    +                    
<term><property>ldap-dereference-aliases</property></term>
    +                    <listitem>
    +                        <para>Controls whether or not the LDAP connection 
follows (dereferences) aliases
    +                            as it searches the tree.  There are four 
possible values: never (the default),
    +                            finding, searching, and always.  Never means 
aliases will never be followed;
    --- End diff --
    
    Similar to the above, starting this sentence with "Never means ..." 
(uppercase N) could lead to confusion when specifying the 
`ldap-dereference-aliases` property, as the values are strictly interpreted. 
Things need to be rephrased/reorganized somehow such that the value itself can 
be written lowercase, exactly as it would appear in `guacamole.properties`, and 
in quotes so it's clear that we're referring to a strict literal value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to