Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/121#discussion_r107336216
  
    --- Diff: 
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/conf/ConfigurationService.java
 ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *   http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing,
    + * software distributed under the License is distributed on an
    + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    + * KIND, either express or implied.  See the License for the
    + * specific language governing permissions and limitations
    + * under the License.
    + */
    +
    +package org.apache.guacamole.auth.cas.conf;
    +
    +import com.google.inject.Inject;
    +import org.apache.guacamole.GuacamoleException;
    +import org.apache.guacamole.environment.Environment;
    +
    +/**
    + * Service for retrieving configuration information regarding the CAS 
service.
    + */
    +public class ConfigurationService {
    +
    +    /**
    +     * The Guacamole server environment.
    +     */
    +    @Inject
    +    private Environment environment;
    +
    +    /**
    +     * Returns the authorization endpoint (URI) of the CAS service as
    +     * configured with guacamole.properties.
    +     *
    +     * @return
    +     *     The authorization endpoint of the CAS service, as configured 
with
    +     *     guacamole.properties.
    +     *
    +     * @throws GuacamoleException
    +     *     If guacamole.properties cannot be parsed, or if the 
authorization
    +     *     endpoint property is missing.
    +     */
    +    public String getAuthorizationEndpoint() throws GuacamoleException {
    +        return 
environment.getRequiredProperty(CASGuacamoleProperties.CAS_AUTHORIZATION_ENDPOINT);
    +    }
    +
    +    /**
    +     * Returns the URI that the CAS service should redirect to after
    +     * the authentication process is complete, as configured with
    +     * guacamole.properties. This must be the full URL that a user would 
enter
    +     * into their browser to access Guacamole.
    +     *
    +     * @return
    +     *     The client secret to use when communicating with the CAS 
service,
    --- End diff --
    
    Looks like some copy pasta here. You mean the redirect URI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to