Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/121#discussion_r108432814
--- Diff: extensions/guacamole-auth-cas/src/main/resources/casConfig.js ---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+/**
+ * Config block which registers CAS-specific field types.
+ */
+angular.module('guacCAS').config(['formServiceProvider',
+ function guacCASConfig(formServiceProvider) {
+
+ // Define field for ticket from CAS service
+ formServiceProvider.registerFieldType("GUAC_CAS_TICKET", {
+ templateUrl : '',
+ controller : 'guacCASController',
+ module : 'guacCAS'
+ });
+
+}]);
+
+/**
+ * Config block which augments the existing routing, providing special
handling
+ * for the "ticket=" parameter provided by the CAS authentication process.
+ */
+angular.module('index').config(['$routeProvider','$windowProvider',
+ function indexRouteConfig($routeProvider,$windowProvider) {
--- End diff --
> This is a .config() block which doesn't actually do any configuration.
Besides being not very Angular-y, this will only run once when the application
first loads. Any time after that will not work as expected, including when
navigating from page to page or after logging out.
What would be the proper place in Angular to do something like this? I
took a stab at creating a new controller in the index module and putting it
there, but I'm guessing the controller functions don't get run automatically
(need to be called), so is there a service/controller/directive/etc. that will
get run automatically, or some place I should call the controller?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
