[GitHub] incubator-guacamole-manual pull request #39: GUACAMOLE-101: Documentation fo...

[mike-jumper]

Github user mike-jumper commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-manual/pull/39#discussion_r108481671
  
    --- Diff: src/chapters/ldap-auth.xml ---
    @@ -395,6 +395,15 @@ dn: cn={4}guacConfigGroup,cn=schema,cn=config
                                 aliases.</para>
                         </listitem>
                     </varlistentry>
    +                <varlistentry>
    +                    
<term><property>ldap-user-search-filter</property></term>
    --- End diff --
    
    OK - I built the manual from these changes and noticed that the 
organization of this section is slightly off. There's a section in the middle 
of this area which is devoted to users and search:
    
    > 
![ldap-user-search-stuff](https://cloud.githubusercontent.com/assets/4632905/24418078/9ab4ca40-139f-11e7-9e1b-e477588be48b.png)
    
    but the new `ldap-user-search-filter` property documentation is simply 
appended to the end of the section among other unrelated properties:
    
    > 
![ldap-user-search-filter-section](https://cloud.githubusercontent.com/assets/4632905/24418107/ba15515c-139f-11e7-8405-2e61f2164435.png)
    
    Perhaps this should be moved up a bit?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---