GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/149
GUACAMOLE-267: Take remote desktop errors into account for balancing groups.
This change adds a new object to guacamole-common,
`FailoverGuacamoleSocket`, which watches for "error" instructions related to
the upstream remote desktop while the Guacamole connection process occurs, and
modifies the balancing group behavior of the database auth to use this class
where applicable.
If an error is encountered, `FailoverGuacamoleSocket` intercepts that
error, rethrowing it as a `GuacamoleUpstreamException` (or subclass). In the
case of the database auth, this results in the connection transparently failing
over to the next available connection in the group. From the user's
perspective, everything just magically works.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-client
failover-socket
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/149.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #149
----
commit 798f06ee0a4e3e72ba303f970d9dded7aa5e29a8
Author: Michael Jumper <[email protected]>
Date: 2017-04-04T19:28:05Z
GUACAMOLE-267: Implement FailoverGuacamoleSocket.
commit 3f38880a1205ea57ecb29e360f8fdf6a06f1e8dd
Author: Michael Jumper <[email protected]>
Date: 2017-04-17T04:02:00Z
GUACAMOLE-267: Avoid unnecessarily rebuilding the Guacamole protocol form
of a GuacamoleInstruction.
commit ad3fcb59ca1f51de630ff864f8624e916b75efd9
Author: Michael Jumper <[email protected]>
Date: 2017-04-17T04:02:59Z
GUACAMOLE-267: Narrow concerns of FailoverGuacamoleSocket to a single
connection. Throw exceptions directly from constructor if upstream errors are
encountered.
commit 8b9b4881b71f60db8fd44c38a96b3c9fa6503909
Author: Michael Jumper <[email protected]>
Date: 2017-04-17T04:10:25Z
GUACAMOLE-267: Do not require ConfiguredGuacamoleSocket for all active
connections.
commit c9b88e2ba927fd6b92a788e67fd936107027919a
Author: Michael Jumper <[email protected]>
Date: 2017-04-17T04:41:56Z
GUACAMOLE-267: Failover to other connections within same group if upstream
remote desktop errors are detected.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
