GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/87
GUACAMOLE-282: Correct common surface transfer functions to copy/ignore
alpha channel as required.
From [GUACAMOLE-282](https://issues.apache.org/jira/browse/GUACAMOLE-282):
>
> The common surface implementation used within guacamole-server is
incorrect with respect to binary transfer functions as of
[GUACAMOLE-188](https://issues.apache.org/jira/browse/GUACAMOLE-188), which
added support for the alpha channel to the common surface.
>
> Prior to
[GUACAMOLE-188](https://issues.apache.org/jira/browse/GUACAMOLE-188), the
common surface supported only the red, green, and blue channels, thus simple
binary operations correctly mirrored those of the JavaScript Guacamole client.
>
> After
[GUACAMOLE-188](https://issues.apache.org/jira/browse/GUACAMOLE-188), the
contents of a surface might have alpha channel values, which are not supposed
to be taken into account for all transfer functions. The JavaScript client
actually only pays attention to the alpha channel for the following transfer
functions:
>
> * `GUAC_TRANSFER_BINARY_SRC` (alpha channel becomes a copy of source)
> * `GUAC_TRANSFER_BINARY_NSRC` (alpha channel becomes a copy of source and
is NOT INVERTED)
>
> In all other cases, the alpha channel of the destination is preserved.
>
> The common surface must be modified to duplicate this behavior.
These changes correct the binary operations such that the destination alpha
channel is maintained except in the two cases where the source alpha channel
must be copied.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server
fix-raster
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/87.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #87
----
commit 691a3ab840038c703fa7123224b8face369cf7d1
Author: Michael Jumper <[email protected]>
Date: 2017-04-24T18:57:12Z
GUACAMOLE-282: Correct common surface transfer functions to copy/ignore
alpha channel as required.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
