Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/86#discussion_r113611774
--- Diff: src/terminal/terminal_handlers.c ---
@@ -779,13 +919,30 @@ int guac_terminal_csi(guac_terminal* term, unsigned
char c) {
/* Foreground */
else if (value >= 30 && value <= 37)
--- End diff --
If you're referring to 30 and 37 here, these are the values from the
standard defining the console codes used by the Guacamole terminal emulator.
Might not be a bad idea to do go through the terminal emulator code and add
constants for all of these, but I'd say we should do that as a separate cleanup
issue, rather than having these be the only two such constants.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
