GitHub user chrisgavin opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/154
Fix an incorrectly positioned bracket.
I spotted this line where `deltaY` is strictly compared against false,
which should never be true because `deltaY` is a number. I believe the correct
behavior is the one expressed on line 153, where the result of the
`guacTouchDrag` function is compared against false.
---
I found this issue through
[lgtm.com](https://lgtm.com/projects/g/apache/incubator-guacamole-client/alerts/),
a service that analyzes open-source code to look for potential problems. (Full
disclosure: I work for the company that operates it.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chrisgavin/incubator-guacamole-client
inconvertable-types
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #154
----
commit 0954c723f36c6bd49380574f1485edfb287bd5b2
Author: Chris Gavin <[email protected]>
Date: 2017-05-07T10:08:11Z
Fix an incorrectly positioned bracket.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
