Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/93#discussion_r123905227
--- Diff: src/common-ssh/ssh.c ---
@@ -532,16 +532,20 @@ guac_common_ssh_session*
guac_common_ssh_create_session(guac_client* client,
return NULL;
}
- /* Configure session keepalive */
- if (keepalive > 0)
- libssh2_keepalive_config(common_session->session, 1, keepalive);
-
/* Warn if keepalive below minimum value */
- if (keepalive == 1) {
+ if (keepalive < 0) {
+ keepalive = 0;
+ guac_client_log(client, GUAC_LOG_WARNING, "negative keepalive
intervals "
+ "are converted to 0, disabling keepalive.");
+ }
+ else if(keepalive == 1) {
--- End diff --
Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
