GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/98
GUACAMOLE-337: Move libguacd functionality into public libguac API.
This change removes the libguacd utility library, moving its functionality
instead into the public libguac library. With these changes, libguac now
provides an SSL/TLS implementation of `guac_socket` (if guacamole-server was
built with SSL support) and a new `guac_user_handle_connection()` function
which deals with the entire Guacamole protocol handshake and subsequent I/O in
a blocking manner.
The new SSL/TLS `guac_socket` is defined within the
`guacamole/socket-ssl.h` header file (rather than within the main
`guacamole/socket.h` header), which will only be installed if SSL support has
been included in the guacamole-server build.
guacd has been refactored to take these changes into account.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server
move-libguacd
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/98.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #98
----
commit a56a7207acfa54bea90404e34e890ed46262a972
Author: Michael Jumper <[email protected]>
Date: 2017-06-10T21:14:42Z
GUACAMOLE-337: Remove unnecessary link to libguac-common for libguacd.
commit 69d8d87ec9a8525957df37ee264558b685ccabc2
Author: Michael Jumper <[email protected]>
Date: 2017-06-10T21:14:57Z
GUACAMOLE-337: Remove unnecessary include of syslog.h by libguacd.
commit 7f3b985cc6597d60507a74e33efd197e1c27c283
Author: Michael Jumper <[email protected]>
Date: 2017-06-11T02:11:52Z
GUACAMOLE-337: Install libguacd as a normal library.
commit 6c484c1efdcf525e97d4b7167123cbbb4e7471f6
Author: Michael Jumper <[email protected]>
Date: 2017-06-11T02:16:22Z
GUACAMOLE-337: Limit public libguacd API to simply user handshake handling
and SSL/TLS sockets.
commit 3a46fffe444a04af2f14c74f3cfe9b7195cb5696
Author: Michael Jumper <[email protected]>
Date: 2017-06-11T02:17:57Z
GUACAMOLE-337: Do not include config.h in libguacd public headers.
commit 78dbf64416d6a8fc44ccfceb4bf4f3ba62eea8c3
Author: Michael Jumper <[email protected]>
Date: 2017-06-11T02:19:43Z
GUACAMOLE-337: Add missing libtool flags for libguacd.
commit f311c23ffa4f8a015ddfe55866a27204d389075d
Author: Michael Jumper <[email protected]>
Date: 2017-06-12T21:06:47Z
GUACAMOLE-337: Move SSL socket into libguac.
commit 06a5043442ee71a7e289169967aa6526bf202d70
Author: Michael Jumper <[email protected]>
Date: 2017-06-12T21:36:20Z
GUACAMOLE-337: Include only *-types.h headers when only types are needed.
commit 5b748a4b4267afe9d6ca38467abcc03a2df7acc9
Author: Michael Jumper <[email protected]>
Date: 2017-07-01T22:24:20Z
GUACAMOLE-337: Separate definition of guacd read timeout from libguacd.
commit f504b1a5e883ac99a6c3f4058a150fb8c2b59c52
Author: Michael Jumper <[email protected]>
Date: 2017-07-01T22:51:15Z
GUACAMOLE-337: Move libguacd functionality into libguac.
commit 60141175ddb2a7ced91a154232eca314efdf8a2d
Author: Michael Jumper <[email protected]>
Date: 2017-07-02T01:55:20Z
GUACAMOLE-337: Document that socket-ssl.h is not guaranteed to be present.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
