Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/102#discussion_r126821765
--- Diff: configure.ac ---
@@ -662,7 +662,7 @@ fi
# Check for stream support via WinPR
if test "x${have_freerdp}" = "xyes"
then
- AC_CHECK_HEADER(winpr/stream.h,,
+ AC_CHECK_HEADER(winpr/stream.h,[RDP_LIBS="$RDP_LIBS -lwinpr-utils"],
--- End diff --
This is unfortunately probably wrong.
This section is specific to one aspect of that WinPR library, so adding the
library here is odd. It would make more sense to add the WinPR library to
`RDP_LIBS` at the point where the final yes/no decision is made regarding
whether WinPR-related parts of the build are enabled, a little bit later:
```
if test "x${have_freerdp}" = "xyes" -a "x${have_winpr}" = "xyes"
then
AC_DEFINE([ENABLE_WINPR],,
[Whether library support for WinPR types was found])
fi
```
I have not looked into the original issue further, but I'm also unsure
whether "libwinpr-utils" is the correct library to add.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
