Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/177#discussion_r127626203
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/schema/001-create-schema.sql
---
@@ -322,6 +322,7 @@ CREATE TABLE `guacamole_connection_history` (
`history_id` int(11) NOT NULL AUTO_INCREMENT,
`user_id` int(11) DEFAULT NULL,
`username` varchar(128) NOT NULL,
+ `remote_host` varchar(128) DEFAULT NULL,
--- End diff --
Do you think we may need more that 128 characters?
Googling around a bit, the maximum length of any particular domain name in
DNS is 253 characters, while fully-qualified hostnames are generally limited to
255 characters on UNIX and others. Based on that, I'd say this should be bumped
up to 256.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
