Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r133610715
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/auth/AuthenticationService.java
---
@@ -208,6 +218,50 @@ private AuthenticatedUser
updateAuthenticatedUser(AuthenticatedUser authenticate
}
/**
+ * Notify all bound AuthenticationSuccessListeners that a successful
authentication
+ * has occurred. If any of the bound listeners returns false
(indicating that the
+ * authentication should be rejected) a
GuacamoleRejectedAuthenticationException is
+ * thrown.
+ *
+ * @param authenticatedUser
+ * The user that was successfully authenticated
+ * @param session
+ * Existing session for the user (if any)
+ * @throws GuacamoleException
+ * If a filter throws an exception or if any filter rejects the
authentication
+ */
+ private void notifyAuthenticationSuccessListeners(
+ AuthenticatedUser authenticatedUser, GuacamoleSession session)
+ throws GuacamoleException {
+ UserContext userContext = null;
--- End diff --
Style nit-pick: Probably good to add a space above this line between the
header and body of the method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
