Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r134754446
--- Diff:
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/ticket/TicketValidationService.java
---
@@ -57,9 +57,7 @@
* If the ID ticket is not valid, the username claim type is
missing, or
* guacamole.properties could not be parsed.
*/
- public String processUsername(String ticket) throws GuacamoleException
{
-
- AttributePrincipal principal = null;
--- End diff --
Glad to see this line go. ;) Never a fan of unnecessary initialization.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
