Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/179#discussion_r135919819
--- Diff:
guacamole/src/main/webapp/app/settings/directives/guacSettingsPreferences.js ---
@@ -192,6 +192,9 @@
angular.module('settings').directive('guacSettingsPreferences', [function guacSe
$scope.canChangePassword =
PermissionSet.hasUserPermission(permissions,
PermissionSet.ObjectPermissionType.UPDATE,
username);
+ })
+ .error(function permissionsFailed(error) {
+ $scope.canChangePassword = false;
--- End diff --
Eh ... unless @jmuehlner disagrees, I withdraw my concerns. I think these
changes are fine.
There are ways to explicitly check for and handle the error response, as
done in other parts of the admin interface, such that the user will see some
useful error message describing the failure... but in this case, I can't think
of any such message which would be appropriate or helpful. It's just the
password edit screen.
If the rest of the webapp's interface handled such errors and always warned
the user when the service is unavailable (for example), that would be another
matter, but that's not currently done, and doing so here would thus be out of
scope.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
