Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/182#discussion_r135948903
--- Diff:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-sqlserver/src/main/resources/org/apache/guacamole/auth/jdbc/connection/ConnectionMapper.xml
---
@@ -0,0 +1,235 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!DOCTYPE mapper PUBLIC "-//mybatis.org//DTD Mapper 3.0//EN"
+ "http://mybatis.org/dtd/mybatis-3-mapper.dtd"; >
+
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one
+ or more contributor license agreements. See the NOTICE file
+ distributed with this work for additional information
+ regarding copyright ownership. The ASF licenses this file
+ to you under the Apache License, Version 2.0 (the
+ "License"); you may not use this file except in compliance
+ with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing,
+ software distributed under the License is distributed on an
+ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ KIND, either express or implied. See the License for the
+ specific language governing permissions and limitations
+ under the License.
+-->
+
+<mapper
namespace="org.apache.guacamole.auth.jdbc.connection.ConnectionMapper" >
+
+ <!-- Result mapper for connection objects -->
+ <resultMap id="ConnectionResultMap"
type="org.apache.guacamole.auth.jdbc.connection.ConnectionModel" >
+
+ <!-- Connection properties -->
+ <id column="connection_id" property="objectID"
jdbcType="INTEGER"/>
+ <result column="connection_name" property="name"
jdbcType="VARCHAR"/>
+ <result column="parent_id"
property="parentIdentifier" jdbcType="INTEGER"/>
+ <result column="protocol" property="protocol"
jdbcType="VARCHAR"/>
+ <result column="max_connections"
property="maxConnections" jdbcType="INTEGER"/>
+ <result column="max_connections_per_user"
property="maxConnectionsPerUser" jdbcType="INTEGER"/>
+ <result column="proxy_hostname" property="proxyHostname"
jdbcType="VARCHAR"/>
+ <result column="proxy_port" property="proxyPort"
jdbcType="INTEGER"/>
+ <result column="proxy_encryption_method"
property="proxyEncryptionMethod" jdbcType="VARCHAR"
+
javaType="org.apache.guacamole.net.auth.GuacamoleProxyConfiguration$EncryptionMethod"/>
+ <result column="connection_weight"
property="connectionWeight" jdbcType="INTEGER"/>
+ <result column="failover_only" property="failoverOnly"
jdbcType="BOOLEAN"/>
+
+ <!-- Associated sharing profiles -->
+ <collection property="sharingProfileIdentifiers"
resultSet="sharingProfiles" ofType="java.lang.String"
+ column="connection_id"
foreignColumn="primary_connection_id">
+ <result column="sharing_profile_id"/>
+ </collection>
+
+ </resultMap>
+
+ <!-- Select all connection identifiers -->
+ <select id="selectIdentifiers" resultType="string">
+ SELECT connection_id
+ FROM [dbo].[guacamole_connection]
--- End diff --
I think it depends. I definitely do not consider myself an expert on SQL
Server; however, unlike PostgreSQL, I believe SQL Server is a little further
down the road toward Oracle of having certain schemas associated with certain
users. When you create a user object in a SQL Server database you can
associate a default schema with that user. So, if an admin create a guacamole
user in for the database and sets the schema to something other than dbo, but
loads the schema using the sa account or something similar, there could be some
confusion for the admin about which schema the tables are in. This forcibly
eliminates that confusion.
I could go the route of just assuming the default schema, if you think
that's better?? It doesn't matter all that much to me...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
