Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/113#discussion_r140931760
--- Diff: src/common-ssh/ssh.c ---
@@ -479,7 +478,7 @@ guac_common_ssh_session*
guac_common_ssh_create_session(guac_client* client,
guac_client_log(client, GUAC_LOG_DEBUG, "Unable to connect to "
"host %s, port %s: %s",
connected_address, connected_port, strerror(errno));
-
+ close(fd);
--- End diff --
Previously, there was a blank line after this single-line `else` block,
visually separating that block from the code that followed. For the sake of
readability, that blank line should remain.
I would suggest either restoring the blank line, adding this `close()` call
to the `else` block itself, or getting rid of the `else` entirely and rely on
the fact that the `if` will `break` out of the loop (and thus the `else` is
superfluous anyway).
---
