Github user necouchman commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/183#discussion_r141375864
  
    --- Diff: 
extensions/guacamole-auth-cas/src/main/java/org/apache/guacamole/auth/cas/AuthenticationProviderService.java
 ---
    @@ -83,7 +115,15 @@ public AuthenticatedUser authenticateUser(Credentials 
credentials)
                 String ticket = 
request.getParameter(CASTicketField.PARAMETER_NAME);
                 if (ticket != null) {
                     AuthenticatedUser authenticatedUser = 
authenticatedUserProvider.get();
    -                
authenticatedUser.init(ticketService.processUsername(ticket), credentials);
    +                AttributePrincipal principal = 
ticketService.validateTicket(ticket);
    +                String username = principal.getName();
    +                Object credObj = 
principal.getAttributes().get("credential");
    +                if (credObj != null) {
    --- End diff --
    
    Okay, I've moved a bunch of the decryption logic over to the 
TicketValidationService class and am returning a CredentialsObject back to the 
AuthenticationProviderService, instead.  How does that look?


---

Reply via email to