Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-client/pull/184#discussion_r143105098
--- Diff:
guacamole/src/main/java/org/apache/guacamole/rest/auth/AuthenticationService.java
---
@@ -208,6 +218,44 @@ private AuthenticatedUser
updateAuthenticatedUser(AuthenticatedUser authenticate
}
/**
+ * Notify all bound listeners that a successful authentication
+ * has occurred.
+ *
+ * @param authenticatedUser
+ * The user that was successfully authenticated
+ * @param session
+ * Existing session for the user (if any)
+ * @throws GuacamoleException
+ * If thrown by a listener
+ */
+ private void fireAuthenticationSuccessEvent(
+ AuthenticatedUser authenticatedUser, GuacamoleSession session)
+ throws GuacamoleException {
+
+ UserContext userContext = null;
+ if (session != null) {
+ userContext = session.getUserContext(
+
authenticatedUser.getAuthenticationProvider().getIdentifier());
+ }
+
+ listenerService.handleEvent(new AuthenticationSuccessEvent(
+ userContext, authenticatedUser.getCredentials()));
+ }
+
+ /**
+ * Notify all bound listeners that an authentication attempt has
failed.
+ *
+ * @param credentials
+ * The credentials that failed to authenticate
+ * @throws GuacamoleException
--- End diff --
Missing blank lines between the various `@param` and `@throws, as well as
the periods.
---
