GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/196
GUACAMOLE-248: Support for connection templates
This PR adds support for for assigning a connection as a template to
another connection, and thus inheriting parameters from the template connection.
The only sort of outstanding issue that needs to be discussed and dealt
with is handling checkbox values. At this point, the a checkbox is unchecked
if the value is null, and checked if it is otherwise (true). It's possible
things will work fine this way; however, the ideal solution would be to
recognize no value as different from false when it comes to boolean options
(checkboxes) so that you can specifically set a boolean parameter to false, and
the value will not be passed through from the template.
This also implements a template chooser, similar to the location chooser,
which keeps the template connections organized a little bit better than just
throwing them in a select box.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-client
GUACAMOLE-248
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/196.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #196
----
commit a8c6ade3049bec7f7feb1ee97c783972bbab6f49
Author: Nick Couchman <[email protected]>
Date: 2017-05-07T19:29:17Z
GUACAMOLE-248: Add fields to support connection templating.
commit 5ab4b4a0ffa95efcc1809208e3351742b9585752
Author: Nick Couchman <[email protected]>
Date: 2017-07-26T03:00:16Z
GUACAMOLE-248: Implement database fields to support templating in JDBC
extension
commit 5e40a5c36e80e6c38dc0cd6405f68be4c2dc98a0
Author: Nick Couchman <[email protected]>
Date: 2017-07-26T15:47:53Z
GUACAMOLE-248: Add triggers to MySQL to prevent setting template to itself.
commit d38652f5bbb5baea19485b33bd2d236a65f78805
Author: Nick Couchman <[email protected]>
Date: 2017-07-29T01:26:41Z
GUACAMOLE-248: Finish rest endpoint getting per-protocol connections.
commit 855657d7b9dc95dce62704e5699dfb4cae6108a7
Author: Nick Couchman <[email protected]>
Date: 2017-07-29T01:59:36Z
GUACAMOLE-248: Fix issue with competing REST endpoints.
commit bd4b68799623ff5b3bf9ff0538b81c5db1be59de
Author: Nick Couchman <[email protected]>
Date: 2017-07-29T02:08:39Z
GUACAMOLE-248: Translation for new field.
commit 6900ac12a22a078b5378da46d7aef11410788c0a
Author: Nick Couchman <[email protected]>
Date: 2017-07-29T02:36:42Z
GUACAMOLE-248: Add support for querying new REST endpoint for per-protocol
connections.
commit 40257de61f589cd6bb8e2ca1a49ee0ef1f0c95a8
Author: Nick Couchman <[email protected]>
Date: 2017-07-30T20:16:55Z
GUACAMOLE-248: WebApp changes to make template field show up and populate.
commit fa2274e288ede3667cebb079849870b698cc418d
Author: Nick Couchman <[email protected]>
Date: 2017-07-31T01:23:42Z
GUACAMOLE-248: Fix up loading of templates on protocol change.
commit 465ff1c7dfe44c96a32d0a41791a92d65db53967
Author: Nick Couchman <[email protected]>
Date: 2017-08-01T18:12:07Z
GUACAMOLE-248: Load parameters from template connection and assign them as
placeholders in the connection form.
commit d83951b345e29c45fee0a76e8dfa0362bec48af3
Author: Nick Couchman <[email protected]>
Date: 2017-08-01T20:10:07Z
GUACAMOLE-248: Add support for pulling & updating the template parameter.
commit dafd1e4adea5d0fdd4def9f93ff20808df09fbcd
Author: Nick Couchman <[email protected]>
Date: 2017-08-01T20:20:18Z
GUACAMOLE-248: Fix selection box and clearing of placeholders.
commit 672ea2665e1ca6a062357eb5c0b8f98e23d8ad3c
Author: Nick Couchman <[email protected]>
Date: 2017-08-01T20:33:41Z
GUACAMOLE-248: Remove unnecessary connectionService method, and add
comments to new method.
commit 0f9363a96d98971a855614a429b4fdfb0d256dd5
Author: Nick Couchman <[email protected]>
Date: 2017-08-01T23:55:42Z
GUACAMOLE-248: Grab template connection parameters and overlay.
commit d8078862037ebbb4472de0ead828456a0ff3b634
Author: Nick Couchman <[email protected]>
Date: 2017-08-20T02:48:32Z
GUACAMOLE-248: Hide self and connections already pointing at a template
from selection field.
commit 7876ab4c2e9ae75e00e23c84ef7347b85ddc7c41
Author: Nick Couchman <[email protected]>
Date: 2017-08-20T19:01:10Z
GUACAMOLE-248: Correct password field behavior for placeholders.
commit 3e5d894846967c2bec97cfcd75f4beb43fec72ab
Author: Nick Couchman <[email protected]>
Date: 2017-08-20T20:17:05Z
GUACAMOLE-248: Add filter for ordering connections in the selection box.
commit a53769d35cc252ecc80752df2eff604c11d736ea
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T14:20:00Z
GUACAMOLE-248: Implement template chooser similar to location chooser.
commit 48a31db364c498b3e2e6c23e8c4e12d27eb328e8
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T14:21:46Z
GUACAMOLE-248: Rename templateConnection to templateConnectionId for
clarity.
commit 6ba26a562c8393303923a558a0c10ab144cbb974
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T14:22:12Z
GUACAMOLE-248: Add missing style sheet for template chooser.
commit e21160452c6183a4a63beccb8308a3a9e31caf8b
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T14:57:26Z
GUACAMOLE-248: Fix issue with loading inherited parameters when template
changes.
commit 03726fe371b4b885ea8978e1f8026092321957ee
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T15:27:07Z
GUACAMOLE-248: Add SQL Server template fields.
commit 057644eb588a48d5d2b77bbb8ff48b020dd5ecda
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T15:50:30Z
GUACAMOLE-248: Clean up unused imports, comments, and style issues.
commit c9c869f4f20e6ff789567dc67126170353a63f93
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T19:40:21Z
GUACAMOLE-248: Fix placeholder/style issues for select and checkbox fields.
commit b65f61acfd6eba10da0d45bbb71a7b8724651765
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T19:42:21Z
GUACAMOLE-248: Remove indeterminate property from checkbox field.
commit 0f394aa667ad79e7cecb6cd1791cc9c7a110f313
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T19:51:31Z
GUACAMOLE-248: Fix style issues for select box and other placeholders.
commit af1990381acf41f4fc5b03f08b96dc255dd693a5
Author: Nick Couchman <[email protected]>
Date: 2017-10-10T19:53:36Z
GUACAMOLE-248: Remove unnecessary injection.
----
---
