GitHub user necouchman opened a pull request:
https://github.com/apache/incubator-guacamole-client/pull/198
GUACAMOLE-415: Add support for SQLite Authentication Module
This pull request adds support for the SQLite JDBC driver to the JDBC
authentication module. There are a couple of things worth noting:
- Support for SQLite in JdbcHelper did not show up until MyBatis Guice 3.9.
I've gone ahead and bumped that version up, and tested it with both SQLite and
PostgreSQL, without an adverse behavior, but that's worth discussing. I think
I can probably get the driver going without the JdbcHelper by manually setting
JDBC.driver and JDBC.url properties, if we don't want to rev the MyBatis Guice
version - just let me know.
- There's a bug [1] in the SQLite JDBC driver that impacts parameters being
inserted into prepared statements, and, as a result, I had to break the select
statements for this driver into individual blocks, which resulted in some badly
duplicated XML code. It works, it's just not ideal, from a maintainability or
performance perspective.
[1] [https://github.com/xerial/sqlite-jdbc/issues/277](url)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/necouchman/incubator-guacamole-client
working/sqlite
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-client/pull/198.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #198
----
commit 862be949a2843c30da5943725bdd9a982374a5df
Author: Nick Couchman <[email protected]>
Date: 2017-10-13T16:47:32Z
GUACAMOLE-415: Implementation of SQLite module for JDBC Authentication
Provider
----
---
