Github user mike-jumper commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/118#discussion_r146481288
--- Diff: src/protocols/ssh/client.c ---
@@ -70,8 +70,12 @@ int guac_ssh_client_free_handler(guac_client* client) {
/* Free terminal (which may still be using term_channel) */
if (ssh_client->term != NULL) {
- guac_terminal_free(ssh_client->term);
+ /* Stop the terminal to terminate ssh_input_thread */
--- End diff --
This is somewhat confusing, as the `pthread_join()` call which immediately
follows deals with the client thread. Perhaps there is a way to word this such
that it is more relevant?
---
