Github user necouchman commented on a diff in the pull request:
https://github.com/apache/incubator-guacamole-server/pull/120#discussion_r148563508
--- Diff: src/protocols/vnc/user.c ---
@@ -112,8 +112,10 @@ int guac_vnc_user_leave_handler(guac_user* user) {
guac_vnc_client* vnc_client = (guac_vnc_client*) user->client->data;
- /* Update shared cursor state */
- guac_common_cursor_remove_user(vnc_client->display->cursor, user);
+ if (vnc_client && vnc_client->display && vnc_client->display->cursor) {
--- End diff --
I'd say go ahead and update with a commit to remove the vnc_client check
but keep the other two. Mike can weigh in on checking cursor and then we can
get this merged.
Thanks!
---
