Github user flangelo commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-client/pull/209#discussion_r150694859
  
    --- Diff: guacamole-common-js/src/main/webapp/modules/Keyboard.js ---
    @@ -984,8 +1003,15 @@ Guacamole.Keyboard = function(element) {
                 // Release specific key if known
                 var keysym = first.keysym;
                 if (keysym) {
    +
    +                // Press CapsLock first if Keyup event is alone.
    +                // 
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#Special_cases
    +                if (keysym === 0xFFE5)
    +                    guac_keyboard.press(keysym);
    --- End diff --
    
    You are correct; looking for the Keydown and Keyup events have no effect:
    ```
    3.key,5.65509,1.1;  18      15:08:08.502
    3.key,5.65509,1.0;  18      15:08:08.503
    3.key,5.65509,1.1;  18      15:08:08.513
    3.key,5.65509,1.0;  18      15:08:08.513
    ```
    This leaves relying only on assuming Mac OS is quirky; which may be true 
until the behavior is 
    fixed in the browser(s) and we'd have to handle that later.. Are we OK with 
that though.


---

Reply via email to