[GitHub] incubator-guacamole-server pull request #123: GUACAMOLE-273: Add Brazillian ...

[flangelo]

Github user flangelo commented on a diff in the pull request:

    
https://github.com/apache/incubator-guacamole-server/pull/123#discussion_r150935771
  
    --- Diff: src/protocols/rdp/keymaps/pt_br_qwerty.keymap ---
    @@ -0,0 +1,58 @@
    +#
    +# Licensed to the Apache Software Foundation (ASF) under one
    +# or more contributor license agreements.  See the NOTICE file
    +# distributed with this work for additional information
    +# regarding copyright ownership.  The ASF licenses this file
    +# to you under the Apache License, Version 2.0 (the
    +# "License"); you may not use this file except in compliance
    +# with the License.  You may obtain a copy of the License at
    +#
    +#   http://www.apache.org/licenses/LICENSE-2.0
    +#
    +# Unless required by applicable law or agreed to in writing,
    +# software distributed under the License is distributed on an
    +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +# KIND, either express or implied.  See the License for the
    +# specific language governing permissions and limitations
    +# under the License.
    +#
    +
    +parent  "base"
    +name    "pt-br-qwerty"
    +freerdp "KBD_PORTUGUESE_BRAZILIAN_ABNT2"
    +
    +#
    +# Basic keys
    +#
    +
    +map -altgr -shift 0x29 0x02..0x0D      ~ "'1234567890-="
    +map -altgr -shift      0x10..0x19 0x1B ~ "qwertyuiop["
    +map -altgr -shift      0x1E..0x27 0x2B ~ "asdfghjklç]"
    +map -altgr -shift 0x56 0x2C..0x36      ~ "\zxcvbnm,.;/"
    +
    +map -altgr +shift 0x29 0x02..0x06 0x08..0x0D ~ ""!@#$%&*()_+"
    +map -altgr +shift      0x10..0x19 0x1B       ~ "QWERTYUIOP{"
    +map -altgr +shift      0x1E..0x27 0x2B       ~ "ASDFGHJKLÇ}"
    +map -altgr +shift 0x56 0x2C..0x36            ~ "|ZXCVBNM<>:?"
    +
    +#
    +# Keys requiring AltGr
    +#
    +
    +map +altgr -shift 0x02..0x07 0x0D ~ "¹²³£¢¬§"
    +map +altgr -shift 0x10..0x11 ~ "/?"
    +map +altgr -shift 0x12 ~ "°"
    +map +altgr -shift 0x12 ~ "€" # map € to ° so Mac behaves the same as 
PC
    --- End diff --
    
    Right... The Mac ABNT2 keyboard flavor isn't laid out like the standard 
ABNT2 keyboard and produces the Euro symbol in the location the standard ABNT2 
keyboard produces the degree symbol. 
    In other use-cases, we chose to "normalize" this to standard PC behavior. 
It was also believed to be less likely someone in Brazil typing Euro character.


---