Instead of System.exit, throwing IOExecption w/ proper message is better. computeGoalSize() looks too complex. I'll look at it tonight.
Sent from my iPhone On 2012. 9. 24., at 오후 5:05, "Yuesheng Hu (JIRA)" <[email protected]> wrote: > > [ > https://issues.apache.org/jira/browse/HAMA-647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Yuesheng Hu updated HAMA-647: > ----------------------------- > > Attachment: HAMA-647-2.patch > > Please use the second patch. > The new mechanisam guarantee that the number of splits is less (or equal) to > the number of tasks. > >> Make the input spliter robustly >> -------------------------------- >> >> Key: HAMA-647 >> URL: https://issues.apache.org/jira/browse/HAMA-647 >> Project: Hama >> Issue Type: Improvement >> Components: bsp core >> Affects Versions: 0.5.0, 0.6.0 >> Reporter: Yuesheng Hu >> Assignee: Yuesheng Hu >> Priority: Critical >> Fix For: 0.6.0 >> >> Attachments: HAMA-647-2.patch, HAMA-647.patch >> >> >> Currently, the spliter in FileInputFormat is based on the Mapreduce's >> spliter. But, Hama is different from Mapreduce, Hama's task can not be >> pended until the slot becomes free. So, the current spliter is not suitable >> for Hama. When input file is small, it may be ok, but when input is very >> large, the number of splits will be very large too, even our cluster is >> powerful enough to handle the input. More details, please see the comments. > > -- > This message is automatically generated by JIRA. > If you think it was sent incorrectly, please contact your JIRA administrators > For more information on JIRA, see: http://www.atlassian.com/software/jira
