[
https://issues.apache.org/jira/browse/HAMA-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13582024#comment-13582024
]
Thomas Jungblut commented on HAMA-735:
--------------------------------------
I used the normal formatter that is linked here
http://wiki.apache.org/hama/HowToContribute.
Maybe it makes sense to add a formatting target to maven, so the trunk is
always consistent with the latest formatter.
bq.Can we make - V extends WritableComparable<?> into V extends
WritableComparable<? super V>.
I thought so first as well, however there are problems when V is a Text.
Because Text is only BinaryComparable, a superclass of Text and not
Comparable<? extends BinaryComparable> which it actually should be. I know that
this sucks with the type inconsistency, but we can't do anything about it and
we have to stick to <?>.
> Tighten the graph API
> ----------------------
>
> Key: HAMA-735
> URL: https://issues.apache.org/jira/browse/HAMA-735
> Project: Hama
> Issue Type: Improvement
> Components: graph
> Affects Versions: 0.6.0
> Reporter: Thomas Jungblut
> Assignee: Thomas Jungblut
> Fix For: 0.6.1
>
> Attachments: HAMA-735_1.patch
>
>
> Tighten the API by the following improvements:
> - replace the need to provide a new object of vertex parts
> - readState/writeState shouldn't be forced to override (clutters code with
> empty methods)
> - add preconditions for not supplied readers
> - generalize the usage of vertex part classes and unify their usage
> - replace unuseful testcases / test methods
> - simplify graph logic by removing repair functionalities
> - formatting + organize of imports
> - add WritableComparable<?> to the vertex ID for efficient merging of
> vertices and joining of them with messages
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
