----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9561/#review17002 -----------------------------------------------------------
Ship it! everything looks ok to me, especially the vertices storage is abstracted so that multiple implementations can be done (just I'd call VerticesInfo the interface, without 'I' but that's probably a matter of taste..) - Tommaso Teofili On Feb. 22, 2013, 5:08 p.m., Thomas Jungblut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9561/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 5:08 p.m.) > > > Review request for hama. > > > Description > ------- > > Please look for something that could be improved. Also if the logic is too > complicated in several parts. > > > This addresses bug HAMA-704. > https://issues.apache.org/jira/browse/HAMA-704 > > > Diffs > ----- > > /trunk/core/src/main/java/org/apache/hama/bsp/SimpleTaskScheduler.java > 1448916 > > /trunk/core/src/main/java/org/apache/hama/bsp/ft/AsyncRcvdMsgCheckpointImpl.java > 1448916 > > /trunk/core/src/main/java/org/apache/hama/bsp/ft/BSPFaultTolerantService.java > 1448916 > /trunk/core/src/main/java/org/apache/hama/util/ReflectionUtils.java 1448916 > /trunk/core/src/test/java/org/apache/hama/bsp/TestCheckpoint.java 1448916 > /trunk/core/src/test/java/org/apache/hama/monitor/TestFederator.java > 1448916 > > /trunk/examples/src/main/java/org/apache/hama/examples/BipartiteMatching.java > 1448916 > /trunk/examples/src/main/java/org/apache/hama/examples/InlinkCount.java > 1448916 > /trunk/examples/src/main/java/org/apache/hama/examples/MindistSearch.java > 1448916 > /trunk/examples/src/main/java/org/apache/hama/examples/PageRank.java > 1448916 > /trunk/examples/src/main/java/org/apache/hama/examples/SSSP.java 1448916 > /trunk/examples/src/main/java/org/apache/hama/examples/util/TextPair.java > 1448916 > > /trunk/examples/src/test/java/org/apache/hama/examples/BipartiteMatchingTest.java > 1448916 > /trunk/examples/src/test/java/org/apache/hama/examples/PageRankTest.java > PRE-CREATION > /trunk/examples/src/test/java/org/apache/hama/examples/SSSPTest.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/AggregationRunner.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/DiskVerticesInfo.java > PRE-CREATION > /trunk/graph/src/main/java/org/apache/hama/graph/Edge.java 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/GraphJob.java 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/GraphJobMessage.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/GraphJobRunner.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/IDSkippingIterator.java > PRE-CREATION > /trunk/graph/src/main/java/org/apache/hama/graph/IVerticesInfo.java 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/ListVerticesInfo.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/Vertex.java 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/VertexInterface.java > 1448916 > /trunk/graph/src/main/java/org/apache/hama/graph/VertexMessageIterable.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/TestAbsDiffAggregator.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/TestAverageAggregator.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/TestDiskVerticesInfo.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/TestMinMaxAggregator.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/TestSubmitGraphJob.java > 1448916 > /trunk/graph/src/test/java/org/apache/hama/graph/TestSumAggregator.java > PRE-CREATION > /trunk/graph/src/test/java/org/apache/hama/graph/example/PageRank.java > 1448916 > > Diff: https://reviews.apache.org/r/9561/diff/ > > > Testing > ------- > > > Thanks, > > Thomas Jungblut > >
