[ 
https://issues.apache.org/jira/browse/HAMA-723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13667869#comment-13667869
 ] 

Thomas Jungblut commented on HAMA-723:
--------------------------------------

Thanks!

bq.mergeFiles() function of Merger.java, when merging finished, there is no 
call to "dos.close()", data lost may happen. Also, in sortAndSpill function of 
SortedFile.java, os.close() missing.

It is not missing, this is the new try/catch with resources. You can read more 
about that here: 
http://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html

Streams are auto closed when reaching the end of the try block.

                
> Implement sorting in spilling queue.
> ------------------------------------
>
>                 Key: HAMA-723
>                 URL: https://issues.apache.org/jira/browse/HAMA-723
>             Project: Hama
>          Issue Type: Sub-task
>          Components: bsp core
>            Reporter: Suraj Menon
>             Fix For: 0.7.0
>
>
> Implement sorted queue. The sender queue can send segments of sorted data and 
> the receiver queue should implement merge sort.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to