[jira] [Commented] (HAMA-833) Add more finish states for vertices

[Edward J. Yoon (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HAMA-833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855627#comment-13855627
 ] 

Edward J. Yoon commented on HAMA-833:
-------------------------------------

I've tested like you: 

{code}
      if (this.getSuperstepCount() == 0) {
        this.setValue(new DoubleWritable(1));
      } else if (this.getSuperstepCount() == 1) {
        if(this.getVertexID().equals(new Text("2"))) {
          this.voteToHalt();
        }
      } else if (this.getSuperstepCount() == 2) {
        System.out.println("vertexID "+ this.getVertexID() +" : " + 
this.getLastAggregatedValue(0));
      } else if (this.getSuperstepCount() == 3) {
        System.out.println("vertexID "+ this.getVertexID() +" : " + 
this.getLastAggregatedValue(0));
      }

Result: 

vertexID 0 : 1.0
vertexID 4 : 1.0
vertexID 6 : 1.0
vertexID 8 : 1.0
vertexID 1 : 1.0
vertexID 3 : 1.0
vertexID 5 : 1.0
vertexID 7 : 1.0
vertexID 9 : 1.0
----
vertexID 0 : 1.0
vertexID 4 : 1.0
vertexID 6 : 1.0
vertexID 8 : 1.0
vertexID 1 : 1.0
vertexID 3 : 1.0
vertexID 5 : 1.0
vertexID 7 : 1.0
vertexID 9 : 1.0
{code}

Halted vertex doesn't called, and I don't see any problem. 

Can you attach your full test code? I don't know what are you talking about.

> Add more finish states for vertices
> -----------------------------------
>
>                 Key: HAMA-833
>                 URL: https://issues.apache.org/jira/browse/HAMA-833
>             Project: Hama
>          Issue Type: Improvement
>          Components: graph
>    Affects Versions: 0.6.3
>            Reporter: Anastasis Andronidis
>            Assignee: Anastasis Andronidis
>            Priority: Minor
>              Labels: features
>             Fix For: 0.7.0
>
>
> We should handle more cases on the vertices, like:
> 1) voteToStop() : Immediately stop the vertex compute and suppress any 
> further calculations on top of that. (e.g. aggregation)
> 2) voteToTerminate(): Immediately stop the vertex compute, suppress any 
> further calculations on top of that and deactivate the vertex so even if any 
> message reaches it, will not come alive.
> Any comments?



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)