[ https://issues.apache.org/jira/browse/HAMA-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13879380#comment-13879380 ]
Hudson commented on HAMA-857: ----------------------------- SUCCESS: Integrated in Hama-trunk #250 (See [https://builds.apache.org/job/Hama-trunk/250/]) HAMA-857: Graph Combiners is wrongly implemented (edwardyoon) (edwardyoon: rev 1560570) * /hama/trunk/CHANGES.txt * /hama/trunk/core/src/main/java/org/apache/hama/bsp/BSPPeerImpl.java * /hama/trunk/core/src/main/java/org/apache/hama/bsp/message/AbstractMessageManager.java * /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJob.java * /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJobMessage.java * /hama/trunk/graph/src/main/java/org/apache/hama/graph/GraphJobRunner.java * /hama/trunk/graph/src/main/java/org/apache/hama/graph/OutgoingVertexMessagesManager.java > Graph Combiners is wrongly implemented > -------------------------------------- > > Key: HAMA-857 > URL: https://issues.apache.org/jira/browse/HAMA-857 > Project: Hama > Issue Type: Bug > Components: graph > Affects Versions: 0.6.3 > Reporter: Edward J. Yoon > Assignee: Edward J. Yoon > Priority: Critical > Fix For: 0.7.0 > > Attachments: HAMA-857_v02.patch, combine.patch > > > Current implementation combines the already received messages. > {code} > if (combiner != null) { > M combined = combiner.combine(iterable); > vertex.compute(Collections.singleton(combined)); > } else { > vertex.compute(iterable); > } > {code} > Messages should be combined before sending to another vertex. -- This message was sent by Atlassian JIRA (v6.1.5#6160)