Hello,

I’m sorry, this appears to be related to my issue HAMA-839.

I don’t know why this code has been removed but I will investigate it!

Best regards
Martin

> Am 05.10.2015 um 08:09 schrieb Edward J. Yoon <[email protected]>:
> 
> Hello,
> 
> Can someone explain why below code has been removed?
> 
> Index: core/src/main/java/org/apache/hama/pipes/protocol/UplinkReader.java
> ===================================================================
> --- core/src/main/java/org/apache/hama/pipes/protocol/UplinkReader.java
> (revision 1556897)
> +++ core/src/main/java/org/apache/hama/pipes/protocol/UplinkReader.java
> (working copy)
> 
> @@ -99,10 +104,9 @@
>         }
> 
>         int cmd = readCommand();
> -        if (cmd == -1) {
> -          continue;
> -        }
> -        LOG.debug("Handling uplink command: " + MessageType.values()[cmd]);
> +        LOG.debug("Handling uplink command: " + cmd);
> +        // MessageType.values()[cmd] may cause NullPointerException (bad
> +        // command)
> 
> 
> --
> Best Regards, Edward J. Yoon

Attachment: signature.asc
Description: Message signed with OpenPGP using GPGMail

Reply via email to