Oh, how nice: duplicate 3604 lines
classlib/modules/portlib/src/main/native/thread/linux/hythread.c
classlib/modules/portlib/src/main/native/thread/windows/hythread.c

Actually whole files are identical modulo formatting and
hythread_current_stack_free(void) implementation is empty on linux.

And a lot of duplicated headers in luni & portlib...


2006/11/23, Alexey Petrenko <[EMAIL PROTECTED]>:
2006/11/23, Alexei Fedotov <[EMAIL PROTECTED]>:
> I like it!
>
> When I ran CPD on C code base it discovered more than cut&paste
> problems. Usually the code which contained big cut&pasted fragments
> had design problems as well. I wonder if it is true for Harmony.
>
> 1. I have no idea if and how java.* packages should be fixed. We don't
> have much freedom there.
> 2. The first comment of X11 and Win32 files from nativebridge package
> tells that they are autogenerated. Should we do anything about them?
I think we can leave these files as is.

SY, Alexey

Reply via email to