2007/1/16, Vladimir Ivanov <[EMAIL PROTECTED]>:
On 1/16/07, Alexey Varlamov <[EMAIL PROTECTED]> wrote:> Folks, > > I've some concerns with recent updates for x-list support: can we use > a common macros instead of copy-pasting 4 new targets into build.xml > for each module? > Or, if we can neglect creating a compiled x-file > (${hy.hdk}/build/<module>.exclude), just use "if" attribute of > <excludesfile>, like this: > > <available property="x.list.exist" > file="exclude.${hy.platform}.${hy.test.vm.name}"/> > ... > <batchtest> > <fileset dir="${src.test.java}"> > <include name="**/*Test.java"/> > <excludesfile name="exclude.common"/> > <excludesfile name="${exclude.file} if="x.list.exist" > /> > </fileset> > </batchtest> The exclude.common also may be missed. And I hope in nearest future Harmony will support module-based work so exclude lists should be copied to somewhere in HDK to run tests. Also I prefer one exclude list for each module in built space.
Yes, this is quite reasonable. Then let's iron out the current approach, via macros?
Also, I suggest to delete empty x-list remained after introducing common > lists. > > Another issue is with "hy.test.vm.name", it was a surprise for me that > it is not autodetected yet. Most obvious way to get it is to read > "java.vm.name" property, this only requires running trivial test. This feature will be implemented soon.
Thanks for volunteering!
Thanks, Vladimir > -- > Alexey >
