Hi, Vladimir: It is good that junit will kill the hanging testcase. I have reported it as HARMONY-3036 and have given a patch. Hope it will work. :)
Good luck! Leo. On 1/22/07, Vladimir Ivanov <[EMAIL PROTECTED]> wrote:
On 1/22/07, Leo Li <[EMAIL PROTECTED]> wrote: > > Hi, Vladimir: > You are right. The testcase seems to be unstable. The most > reliable solution, I think, is to wait in a loop till the sheduled > task does run. However, if there exists a bug in the tested class, the > testcase might trap in an endless loop, which I am not sure whether > the situation is acceptable although everything will be ok if no bug > exists in source code. > If it is acceptable, I will try to make a patch to fix the problem. Thanks Leo! I think it is acceptable to wait in the endless loop (with Thread.yield() built-in) because in this case this test will be finished be timeout (default value is 15min) by junit task. thanks, Vladimir > Good luck! > Leo. > > On 1/19/07, Vladimir Ivanov <[EMAIL PROTECTED]> wrote: > > Today I see 2 new failures of classlib tests on DRLVM (log below). Note, > it > > happens on overload box only (the drlvm build requires ~40 minutes > instead > > of ~10 on similar box). > > > > Seems, these tests depends on computer reaction speed. Could somebody > check > > it? > > > > thanks, Vladimir > > > > Execution log: > > nstdrlel18:classlib/trunk> > > drlvm/trunk/build/lnx_em64t_gcc_debug/deploy/jdk/jre/bin/java -cp > > > modules/luni/bin/test:depends/jars/junit_3.8.2/junit.jar:deploy/build/test/support.jar > > junit.textui.TestRunner tests.api.java.util.TimerTest > > .....F....... > > Time: 14.485 > > There was 1 failure: > > 1) > > test_cancel(tests.api.java.util.TimerTest > )junit.framework.AssertionFailedError: > > TimerTask.run() method should be called 5 times not 4 > > at tests.api.java.util.TimerTest.test_cancel(TimerTest.java:277) > > at java.lang.reflect.VMReflection.invokeMethod(Native Method) > > > > FAILURES!!! > > Tests run: 12, Failures: 1, Errors: 0 > > > > nstdrlel18:classlib/trunk> > > drlvm/trunk/build/lnx_em64t_gcc_debug/deploy/jdk/jre/bin/java -cp > > > modules/luni/bin/test:depends/jars/junit_3.8.2/junit.jar:deploy/build/test/support.jar > > junit.textui.TestRunner tests.api.java.util.TimerTaskTest > > ..F..F > > Time: 2.872 > > There were 2 failures: > > 1) > > test_cancel(tests.api.java.util.TimerTaskTest > )junit.framework.AssertionFailedError: > > TimerTask.cancel() should return false if task has run > > tests.api.java.util.TimerTaskTest.test_cancel(TimerTaskTest.java > :135) > > java.lang.reflect.VMReflection.invokeMethod(Native Method) > > 2) > > test_run(tests.api.java.util.TimerTaskTest > )junit.framework.AssertionFailedError: > > TimerTask.run() method should have been called at least 4 times > > tests.api.java.util.TimerTaskTest.test_run(TimerTaskTest.java:303) > > java.lang.reflect.VMReflection.invokeMethod(Native Method) > > > > FAILURES!!! > > Tests run: 4, Failures: 2, Errors: 0 > > > > > > > -- > Leo Li > China Software Development Lab, IBM >
-- Leo Li China Software Development Lab, IBM
