Alexey,
I suggest the following additions to the "Resolving Issues.If the issue is a bug" to make committers life much easier :)
Well, sounds good :)
1. All the newly introduced message strings should be internationalized
+1. However, there are some exceptions. The pack200 module for example.
2. All the patches should have an evaluation comment
Do you suggest to add a JIRA comment describing the patch or to comment inside the patch itself?
3. If you change two lines of code please make sure that you patch includes only these two lines and do not include any other changes like code formatting. 4. Add yourself to the list of watchers to receive comments and concerns on your patch.
+1 Regards, 2007/2/5, Alexey Petrenko <[EMAIL PROTECTED]>:
Guys, I think we need a little update for the "Good issue resolution guideline" [1] I suggest the following additions to the "Resolving Issues.If the issue is a bug" to make committers life much easier :) 1. All the newly introduced message strings should be internationalized 2. All the patches should have an evaluation comment 3. If you change two lines of code please make sure that you patch includes only these two lines and do not include any other changes like code formatting. 4. Add yourself to the list of watchers to receive comments and concerns on your patch. Thoughts? Concerns? Objections? SY, Alexey [1] http://harmony.apache.org/issue_resolution_guideline.html
-- Alexei Zakharov, Intel ESSD
